Update youtube-rewriter error handling to pass captioning errors as ChatCraft message #625
Conversation
… ImportCommand as ChatCraftHumanMessage
| }); | ||
| } catch (error) { | ||
| return new Response(`**Error**: ${error?.message}`, { | ||
| headers: { "Content-Type": "text/markdown; charset=UTF-8" }, |
There was a problem hiding this comment.
This is probably OK, but I've never seen Markdown used as an Error body before.
There was a problem hiding this comment.
I wanted to bold it like the "Command" text, but I hadn't considered whether we should include Markdown in an Error body.
I can remove the Markdown for now
There was a problem hiding this comment.
Usually an error is informational, not stylistic. You don't want to assume too much about how the client will use it.
There was a problem hiding this comment.
I recently removed Markdown styling from the error message:
return new Response(`Error: ${error?.message}`, {
I had both fixes in one branch and found that only this fix would be triggered if an error occured (there'd be a ChatCraft message but no Error Toast). |
Deploying chatcraft-org with
|
| Latest commit: |
48951a4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://62f568e2.console-overthinker-dev.pages.dev |
| Branch Preview URL: | https://issue-605-2.console-overthinker-dev.pages.dev |
This fixes #605
Background
If you use /import with a Youtube video that either has no English captions or no captions at all, ChatCraft will throw a non-descriptive error toast:
Caption extraction for YouTube videos is handled by youtube-captions-scraper within functions/lib/rewriters/youtube-rewriter.ts.
A previous PR for this (#618) would extract unhandled error messages from the HTML of a generated CloudFlare Pages page and put it inside an Error Toast.
Fix
In this PR, any errors thrown in youtube-rewriter will show up in the /import Response (as a ChatCraft message):
