Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the loading spinner does not disappear when image generation fails #591

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Fix the loading spinner does not disappear when image generation fails #591

merged 1 commit into from
Apr 15, 2024

Conversation

mingming-ma
Copy link
Collaborator

Fixes #590

Make sure closeLoading(alertId); will always be called, so the loading spinner can disappear whether an error is thrown or not.

@mingming-ma mingming-ma self-assigned this Apr 15, 2024
@mingming-ma mingming-ma added this to the Release 2.0 milestone Apr 15, 2024
@mingming-ma mingming-ma added the hotfix a small piece of code developed to correct a major software bug and released as quickly as possible label Apr 15, 2024
Amnish04
Amnish04 approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@Amnish04 Amnish04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mingming-ma Works well. Thanks for the fix!

@mingming-ma mingming-ma merged commit 36af0b2 into main Apr 15, 2024
4 checks passed
@mingming-ma mingming-ma deleted the mingming/bugfix#590 branch April 21, 2024 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amnish04 Amnish04 Amnish04 approved these changes

Assignees

@mingming-ma mingming-ma

Labels
hotfix a small piece of code developed to correct a major software bug and released as quickly as possible
Projects
None yet
Milestone
Release 2.0
Development

Successfully merging this pull request may close these issues.

The loading spinner does not disappear when image generation fails
2 participants
@mingming-ma @Amnish04