Skip to content

Hide voice selection option in prefs menu when tts is not supported #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

Amnish04
Copy link
Collaborator

@Amnish04 Amnish04 commented Apr 3, 2024

This is to make sure that the voice selection options in Preferences Modal are hidden when TTS is not supported by the current provider.

With OpenAI:

image

With Free Provider:

image

Fixes #523

@Amnish04 Amnish04 self-assigned this Apr 3, 2024
@Amnish04 Amnish04 requested a review from kliu57 April 3, 2024 23:36
Copy link
Collaborator

@kliu57 kliu57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this with OpenAi and a custom new openAI provider and works well for showing the voice section. And when tested with free model or openrouter it works well for hiding the voice section. LGTM

@kliu57 kliu57 added this to the Release 1.8 milestone Apr 4, 2024
Copy link

cloudflare-workers-and-pages bot commented Apr 4, 2024

Deploying chatcraft-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: 157e2b2
Status: ✅  Deploy successful!
Preview URL: https://61d6af52.console-overthinker-dev.pages.dev
Branch Preview URL: https://amnish04-issue-523.console-overthinker-dev.pages.dev

View logs

@Amnish04 Amnish04 force-pushed the amnish04/issue-523 branch from 7c605d1 to 157e2b2 Compare April 4, 2024 01:40
@Amnish04
Copy link
Collaborator Author

Amnish04 commented Apr 4, 2024

@kliu57 Thanks for reviewing!

@Amnish04 Amnish04 merged commit d2226e0 into main Apr 4, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Voice Selection setting when TTS is not supported
2 participants