-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the Providers selection Menu Group to easy switch between providers #535
Conversation
We've got the same alignment issue here that you fixed elsewhere. All of the providers should be indented the same amount (left margin) and the icon only showing beside the selected provider. It shouldn't indent the text when the checkbox is beside it (e.g., the text should already be at that position). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes requested. Also you have to make the change from settings.provider using the apiUrl as the key to using name as the key once the hotfix #537 is merged, thanks.
Deploying chatcraft-org with Cloudflare Pages
|
@kliu57 Do you want me change key based on name now or after the PR has been merged. I believe that it would be better to do it after merge as I would be able to test what I'm implementing. Or maybe.. I get this merged and get a PR ready to fix stuff which could be merged right after your PR. @humphd, What would be the best approach for this? Could you please also review the indentation changes based on your feedback? |
You cannot make the change until after my hotfix is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not loving the checkmark icon. I wonder if there is something better, maybe an arrow that points at the one
Maybe we should use a right-hand pointing chevron? https://react-icons.github.io/react-icons/search/#q=chevron
Something like:
Another thing I notice: when you change providers, it closes the menu, which is surprising, since you are probably going to want to pick a model from the new list. Can we make it so that choosing the provider doesn't close the menu?
@humphd , I changed the icon based on your feedback but not sure how can we achieve the second thing? I tried. using disclosure but even that didn't work. Maybe it has to close the menu after switching providers because it has to re render the model based on the change. |
What if you call |
Nope doesn't work |
@humphd , Found this which works for us. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing the refactoring I asked for, everything looks good to me.
Closes #510
Tasks Completed:
Files Changed:
PromptForm.tsx
Screenshots: