Cap submenu maxHeight to 50vh to prevent weird autoscroll #495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
fe885fe
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2a0bcdd7.console-overthinker-dev.pages.dev |
| Branch Preview URL: | https://amnish04-issue-452.console-overthinker-dev.pages.dev |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been an issue for a long time. When we have a lot of items in a submenu, we get a weird autoscroll that tried to focus the first element of the list (which was not able to fit in the available viewport height).
I tried to fix this in #487, but it had a subtle mistake where I set
maxHeightto50vwinstead of50vhdue to which the bug wasn't fixed properly.I have corrected that mistake and the results are much better now.
This fixes #454