Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Margin in free provider banner #620

Closed
humphd opened this issue Apr 29, 2024 · 3 comments
Closed

Margin in free provider banner #620

humphd opened this issue Apr 29, 2024 · 3 comments

Comments

@humphd
Copy link
Collaborator

humphd commented Apr 29, 2024

On mobile, I notice that the close button in the free provider banner is overlapping the text:

Screenshot 2024-04-29 at 8 50 06 AM

We should add some margin similar to how the info icon is on the left.
@priyasirohi09
Copy link
Contributor

This is happening because the close button has position as absolute

@humphd
Copy link
Collaborator Author

humphd commented Apr 30, 2024

Want to work on this next @priyasirohi09?

@priyasirohi09
Copy link
Contributor

priyasirohi09 commented May 7, 2024 •
edited
Loading

Sure @humphd

priyasirohi09 pushed a commit to priyasirohi09/chatcraft.org that referenced this issue May 7, 2024
Fix tarasglek#620 margin in provider banner
251c3e6
@humphd humphd closed this as completed in b96e5e3 May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@humphd @priyasirohi09