api: add support of a batch insert request #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmyger
force-pushed
the
dmyger/gh-399-add-support-IPROTO_INSERT_ARROW
branch
11 times, most recently
from
1f88b6f
to
b6ad2cc
Compare
oleg-jukovec
reviewed
Oct 7, 2024
|
|
oleg-jukovec
reviewed
Oct 8, 2024
Environment variable TARANTOOL_BIN can be used to specify path of Tarantool executable.
dmyger
force-pushed
the
dmyger/gh-399-add-support-IPROTO_INSERT_ARROW
branch
from
b6ad2cc
to
d7e9eab
Compare
oleg-jukovec
requested changes
Oct 8, 2024
dmyger
force-pushed
the
dmyger/gh-399-add-support-IPROTO_INSERT_ARROW
branch
2 times, most recently
from
b00104f
to
a994eb0
Compare
Add support the IPROTO_INSERT_ARROW request and message pack type MP_ARROW. Closes #399
dmyger
force-pushed
the
dmyger/gh-399-add-support-IPROTO_INSERT_ARROW
branch
from
a994eb0
to
53310a5
Compare
oleg-jukovec
approved these changes
Oct 9, 2024
Comment on lines
+68
to
+100
| func TestEncodeArrow(t *testing.T) { | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
| buf := bytes.NewBuffer([]byte{}) | ||
| enc := msgpack.NewEncoder(buf) | ||
|
|
||
| arr, err := arrow.MakeArrow(tt.arr) | ||
| require.NoError(t, err) | ||
|
|
||
| err = enc.Encode(arr) | ||
| require.NoError(t, err) | ||
|
|
||
| require.Equal(t, tt.enc, buf.Bytes()) | ||
| }) | ||
|
|
||
| } | ||
| } | ||
|
|
||
| func TestDecodeArrow(t *testing.T) { | ||
| for _, tt := range tests { | ||
| t.Run(tt.name, func(t *testing.T) { | ||
|
|
||
| buf := bytes.NewBuffer(tt.enc) | ||
| dec := msgpack.NewDecoder(buf) | ||
|
|
||
| var arr arrow.Arrow | ||
| err := dec.Decode(&arr) | ||
| require.NoError(t, err) | ||
|
|
||
| require.Equal(t, tt.arr, arr.Raw()) | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
There are no negative scenarios here, only positive ones. Please, add cases with encoding (if possible)/decoding (should be possible) errors.
There was a problem hiding this comment.
Maybe rename config.lua -> config-memtx.lua, config-ee.lua -> config-memcs.lua? Up to you.
Comment on lines
+56
to
+58
| if len(resp) == 0 { | ||
| fmt.Printf("Batch arrow inserted") | ||
| } |
There was a problem hiding this comment.
So our intention is a little more clear.
Suggested change
| if len(resp) == 0 { | |
| fmt.Printf("Batch arrow inserted") | |
| } | |
| if len(resp) > 0 { | |
| log.Fatalf("Unexpected response") | |
| } | |
| fmt.Printf("Batch arrow inserted") |
Comment on lines
+32
to
+33
| // NewInsertRequest returns a new empty InsertRequest. | ||
| func NewInsertRequest(space interface{}) *InsertRequest { |
There was a problem hiding this comment.
I think this will make using the request a little more useful. But we need to have the Arrow method as well.
Suggested change
| // NewInsertRequest returns a new empty InsertRequest. | |
| func NewInsertRequest(space interface{}) *InsertRequest { | |
| // NewInsertRequest returns a new empty InsertRequest. | |
| func NewInsertRequest(space interface{}, arrow Arrow) *InsertRequest { |
| request := arrow.NewInsertRequest(validSpace) | ||
| resp, err := request.Response(header, bytes.NewBuffer(buf.Bytes())) | ||
| require.NoError(t, err) | ||
| require.IsType(t, baseResponse, resp) |
There was a problem hiding this comment.
Let's do without this (IsType) check. It tells too much of the internal implementation and will complicate refactoring in the future.
| request := arrow.NewInsertRequest(validSpace) | ||
| resp, err := request.Response(header, bytes.NewBuffer(buf.Bytes())) | ||
| require.NoError(t, err) | ||
| require.IsType(t, baseResponse, resp) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft changes: add support the IPROTO_INSERT_ARROW request and message pack type MP_ARROW .
Closes #399