Replace x/sys for go 1.17#618
Conversation
|
@mRrvz woould you be able to merge this and cut a new release |
|
Will it not be enough just to merge? Why do you want a release? @roopakv |
|
It helps not pinning to a commit on brew. Even a patch helps |
|
(I'm not experienced in Go, so, please, don't take my questions as nitpicking.) Why What also doubts me: now we should keep in the mind to don't forget to update x/sys from time to time, right? Can we require I'm not sure it really should be fixed on Go modules side (it looks as a problem of distributions like homebrew), but I don't mind to workaround it anyway. For the history sake: the original issue is golang/go#45702. |
|
@roopakv please answer the question above |
|
replace because x/sys is a transitive dependency so require wont work, replace works for nested deps. cannot do x >= with go. The team will need to remove this later This is not a problem on homebrew, but a problem in x/sys and go 1.17. cartridge-cli needs this change to work with go 1.17 |
|
Thank you for the clarification. I don't mind the change. |
This updates x/sys for the sdk and therefor adds support for go 1.17. More info here Homebrew/homebrew-core#83413
I didn't forget about
Closes #???