Add checksig for vault keypair #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rot13maxi
reviewed
Sep 26, 2024
src/vault/contract.rs
Outdated
| .finalize(&secp, nums_key) | ||
| .expect("finalizing taproot spend info with a NUMS point should always work")) | ||
| } | ||
|
|
||
| fn x_only_public_key(&self) -> XOnlyPublicKey { | ||
| return self.keypair.unwrap().x_only_public_key().0 |
There was a problem hiding this comment.
since the VaultCovenant structure has keypair as an Option, this should probably return an Option or we should require that VaultCovenant has a keypair
There was a problem hiding this comment.
I have updated it so that keypair is now required for VaultCovenant
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a stab at adding a CHECKSIGVERIFY to the scripts which check against a keypair that the vault commits to when created. let me know if I didn't get it quite right or if there is anything you don't like about my implementation, happy to make changes!