Limit orders on PTN #577
Open
Limit orders on PTN #577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit db9aeb8)
(cherry picked from commit b8a3b91)
(cherry picked from commit 2712254)
(cherry picked from commit 03dc68f)
(cherry picked from commit 548e8dd)
(cherry picked from commit 3c1a1df)
(cherry picked from commit d4d0985)
(cherry picked from commit d6be9c1)
(cherry picked from commit 4904a58)
(cherry picked from commit 6262463)
(cherry picked from commit c3c97b2)
The limit orders weren't being fetched correctly via the REST API when using tier-100 API keys (real-time IPC mode) because modifications to lists inside the IPC manager's shared dict weren't properly synchronized. Changes: - Create a copy of the orders list before modifying to avoid unintended changes - Reassign the entire list back to the IPC dict after modifications - Added clear comments emphasizing the importance of not modifying shared data until ready to write the final, validated result This ensures proper synchronization across processes and makes limit orders accessible via the REST API endpoint for tier-100 API keys, matching the behavior of position data fetching. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
rlarkdfus
requested review from
derekawender,
jbonilla-tao,
sli-tao,
taoshidev1 and
trdougherty
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taoshi Pull Request
Support preliminary order filling logic on PTN
Description
[Provide a brief description of the changes introduced by this pull request.]
Related Issues (JIRA)
[Reference any related issues or tasks that this pull request addresses or closes.]
Checklist
Reviewer Instructions
[Provide any specific instructions or areas you would like the reviewer to focus on.]
Definition of Done
Checklist (for the reviewer)
Optional: Deploy Notes
[Any instructions or notes related to deployment, if applicable.]
/cc @mention_reviewer