Update minerstatistics #565
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sli-tao
requested review from
derekawender,
jbonilla-tao,
taoshidev1 and
trdougherty
as code owners
sli-tao
force-pushed
the
feat/asset-incentive-split
branch
from
d2b0eec to
78b84be
Compare
jbonilla-tao
force-pushed
the
feat/asset-incentive-split
branch
from
a87f12b to
7fd88da
Compare
|
I rebased on main |
sli-tao
force-pushed
the
feat/asset-incentive-split
branch
from
7fd88da to
9e95728
Compare
jbonilla-tao
reviewed
Aug 7, 2025
| assert isinstance(x, dict), x | ||
| x['cps'] = [PerfCheckpoint(**cp) for cp in x['cps']] | ||
| x.pop('global_worst_mdd', None) # Remove legacy field if present | ||
| x.pop('last_known_prices', None) # Remove legacy field if present |
There was a problem hiding this comment.
last_known_prices are needed by ledgers now. Please rebase this PR and you won't need this line anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taoshi Pull Request
Description
Add subcategory metrics to minerstatistics
Related Issues (JIRA)
[Reference any related issues or tasks that this pull request addresses or closes.]
Checklist
Reviewer Instructions
[Provide any specific instructions or areas you would like the reviewer to focus on.]
Definition of Done
Checklist (for the reviewer)
Optional: Deploy Notes
[Any instructions or notes related to deployment, if applicable.]
/cc @mention_reviewer