Skip to content

Conversation

@derekawender
Copy link
Contributor

@derekawender derekawender commented May 2, 2025

Taoshi Pull Request

Description

  • Fix challenge period logic for mdd eliminations
  • Remove unnecessary positional filtering
  • Disable websockets in tests

Related Issues (JIRA)

[Reference any related issues or tasks that this pull request addresses or closes.]

Checklist

  • I have tested my changes on testnet.
  • I have updated any necessary documentation.
  • I have added unit tests for my changes (if applicable).
  • If there are breaking changes for validators, I have (or will) notify the community in Discord of the release.

Reviewer Instructions

[Provide any specific instructions or areas you would like the reviewer to focus on.]

Definition of Done

  • Code has been reviewed.
  • All checks and tests pass.
  • Documentation is up to date.
  • Approved by at least one reviewer.

Checklist (for the reviewer)

  • Code follows project conventions.
  • Code is well-documented.
  • Changes are necessary and align with the project's goals.
  • No breaking changes introduced.

Optional: Deploy Notes

[Any instructions or notes related to deployment, if applicable.]

/cc @mention_reviewer

@deepsource-io
Copy link

deepsource-io bot commented May 2, 2025

Here's the code health analysis summary for commits 759a8dd..300b609. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Shell LogoShell✅ SuccessView Check ↗
DeepSource Python LogoPython❌ Failure
❗ 2 occurences introduced
🎯 3 occurences resolved
View Check ↗
DeepSource Test coverage LogoTest coverage✅ Success
🎯 1 occurence resolved
View Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage79.1% (down 0.7% from main)79.1% (down 0.7% from main)
Line Coverage79.1% (down 0.7% from main)79.1% (down 0.7% from main)
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%100%

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants