miner receive signals flask server #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbonilla-tao
reviewed
Mar 6, 2024
| if (self.order_type == OrderTypeEnum.SHORT and self.leverage > 0) or \ | ||
| (self.order_type == OrderTypeEnum.LONG and self.leverage < 0): | ||
| raise ValueError("Leverage must be negative for SHORT orders and positive for LONG orders.") | ||
| if abs(self.leverage) < ValiConfig.MIN_LEVERAGE and self.order_type != OrderTypeEnum.FLAT: |
Collaborator
There was a problem hiding this comment.
No check for MAX_LEVERAGE?
Collaborator
Author
There was a problem hiding this comment.
I dont think we have max leverage yet as a var. We should add that. Will do that as part of this PR
jbonilla-tao
reviewed
Mar 6, 2024
mining/sample_signal_request.py
Outdated
| if __name__ == "__main__": | ||
|
|
||
| # Define the URL endpoint | ||
| url = 'http://127.0.0.1:5000/api/receive-signal' |
Collaborator
Author
There was a problem hiding this comment.
debug port (non-production)
12 tasks
jbonilla-tao
added a commit
that referenced
this pull request
Nov 8, 2025
Issue #2: Remove is_alive() checks from LivePriceFetcher._start_server() - Removed all is_alive() checks that would crash when called from HealthChecker daemon - Use terminate() and kill() directly (safe to call on dead processes) - Rely on connect() to verify server is working instead of process checks - Simplified startup logic with 2s wait + connection attempt Issue #4: Move timestamp update inside lock in auto_sync.py - Moved last_signal_sync_time_ms update into finally block inside lock - Prevents race condition where second sync starts before timestamp updates - Ensures timestamp is always updated even if sync fails Issue #5: Remove unused shutdown_dict logic from daemons - Removed shutdown_dict parameter from HealthChecker.__init__() - Removed shutdown_dict parameter from FeatureRefresher.__init__() - Changed while loops from "while not self.shutdown_dict" to "while True" - Daemons run indefinitely and terminate when main process exits (daemon=True) - Updated validator.py to not pass shutdown_dict to daemon initializations 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
jbonilla-tao
added a commit
that referenced
this pull request
Nov 8, 2025
Issue #2: Remove is_alive() checks from LivePriceFetcher._start_server() - Removed all is_alive() checks that would crash when called from HealthChecker daemon - Use terminate() and kill() directly (safe to call on dead processes) - Rely on connect() to verify server is working instead of process checks - Simplified startup logic with 2s wait + connection attempt Issue #4: Move timestamp update inside lock in auto_sync.py - Moved last_signal_sync_time_ms update into finally block inside lock - Prevents race condition where second sync starts before timestamp updates - Ensures timestamp is always updated even if sync fails Issue #5: Remove unused shutdown_dict logic from daemons - Removed shutdown_dict parameter from HealthChecker.__init__() - Removed shutdown_dict parameter from FeatureRefresher.__init__() - Changed while loops from "while not self.shutdown_dict" to "while True" - Daemons run indefinitely and terminate when main process exits (daemon=True) - Updated validator.py to not pass shutdown_dict to daemon initializations 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taoshi Pull Request
Description
[Provide a brief description of the changes introduced by this pull request.]
Related Issues (JIRA)
[Reference any related issues or tasks that this pull request addresses or closes.]
Checklist
Reviewer Instructions
[Provide any specific instructions or areas you would like the reviewer to focus on.]
Definition of Done
Checklist (for the reviewer)
Optional: Deploy Notes
[Any instructions or notes related to deployment, if applicable.]
/cc @mention_reviewer