Skip to content

fix(stream): fix memory leak #32921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(stream): fix memory leak #32921

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b54033
fix(stream): memory leak
wangmm0220 Sep 9, 2025
9cdb5e3
fix(stream): fix notify content leak in trigger
JinqingKuang Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/dnode/vnode/src/vnd/vnodeStream.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1569,6 +1569,7 @@ static int32_t vnodeProcessStreamTsdbVirtalDataReq(SVnode* pVnode, SRpcMsg* pMsg
SStorageAPI api = {0};
initStorageAPI(&api);
STREAM_CHECK_RET_GOTO(createStreamTask(pVnode, &options, &pTaskInner, NULL, NULL, &api));
STREAM_CHECK_RET_GOTO(taosHashPut(sStreamReaderInfo->streamTaskMap, &key, LONG_BYTES, &pTaskInner, sizeof(pTaskInner)));

STableKeyInfo keyInfo = {.uid = req->tsdbDataReq.uid};
cleanupQueryTableDataCond(&pTaskInner->cond);
Expand All @@ -1578,7 +1579,6 @@ static int32_t vnodeProcessStreamTsdbVirtalDataReq(SVnode* pVnode, SRpcMsg* pMsg
STREAM_CHECK_RET_GOTO(pTaskInner->api.tsdReader.tsdReaderOpen(pVnode, &pTaskInner->cond, &keyInfo, 1, pTaskInner->pResBlock,
(void**)&pTaskInner->pReader, pTaskInner->idStr, NULL));

STREAM_CHECK_RET_GOTO(taosHashPut(sStreamReaderInfo->streamTaskMap, &key, LONG_BYTES, &pTaskInner, sizeof(pTaskInner)));
STREAM_CHECK_RET_GOTO(createOneDataBlock(pTaskInner->pResBlock, false, &pTaskInner->pResBlockDst));
} else {
void** tmp = taosHashGet(sStreamReaderInfo->streamTaskMap, &key, LONG_BYTES);
Expand Down
1 change: 1 addition & 0 deletions source/libs/new-stream/src/streamTriggerTask.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2870,6 +2870,7 @@ static int32_t stRealtimeContextCheck(SSTriggerRealtimeContext *pContext) {
STimeWindow recalcRange = {.skey = pParam->wstart, .ekey = pParam->wend};
code = stTriggerTaskAddRecalcRequest(pTask, pGroup, &recalcRange, pContext->pReaderWalProgress, false);
QUERY_CHECK_CODE(code, lino, _end);
tDestroySSTriggerCalcParam(pParam);
taosArrayPopFrontBatch(pGroup->pPendingCalcParams, 1);
pGroup->recalcNextWindow = false;
}
Expand Down
Loading