enh[TD-37448][TD-37449]: implement show ssmigrate and kill ssmigrate command
#32888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
localvar
requested review from
guanshengliang,
zitsen,
hzcheng and
dapan1121
as code owners
localvar
force-pushed
the
enh/td-37448
branch
from
26425cd to
76cc115
Compare
|
|
localvar
force-pushed
the
enh/td-37448
branch
from
15b44a5 to
88c314d
Compare
xiao-77
reviewed
Sep 11, 2025
|
|
||
| int32_t vgId = *(int32_t*)taosArrayGet(pSsMigrate->vgroups, pSsMigrate->vgIdx); | ||
| while (1) { | ||
| pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup); |
cadem
requested changes
Sep 11, 2025
Comment on lines
619
to
628
| while (1) { | ||
| pIter = sdbFetch(pSdb, SDB_VGROUP, pIter, (void **)&pVgroup); | ||
| if (pIter == NULL) { | ||
| return mndDropSsMigrate(pMnode, pSsMigrate); | ||
| } | ||
| if (pVgroup->vgId == vgId) { | ||
| sdbCancelFetch(pSdb, pIter); | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
这段while，实现的是mndAcquireVgroup这个功能吧？
|
|
||
| _OVER: | ||
| if (code != 0 && code != TSDB_CODE_ACTION_IN_PROGRESS) { | ||
| mError("failed to kill ssmigrate %" PRId32 " since %s", killReq.ssMigrateId, terrstr()); |
| int32_t contLen = reqLen + sizeof(SMsgHead); | ||
| SMsgHead *pHead = rpcMallocCont(contLen); | ||
| if (pHead == NULL) { | ||
| return mndDropSsMigrate(pMnode, pSsMigrate); |
There was a problem hiding this comment.
这几个 drop 都没有问题，mnode drop 过程中向 vnode 发送消息只是为了加速 vnode 端的 drop 操作。但只要 mnode 端没有了，不再进行信息同步，vnode 端就会因为超时而失败。
| pHead->vgId = htonl(vgId); | ||
| int32_t ret = 0; | ||
| if ((ret = tSerializeSVnodeKillSsMigrateReq((char *)pHead + sizeof(SMsgHead), reqLen, &req)) < 0) { | ||
| return mndDropSsMigrate(pMnode, pSsMigrate); |
| mInfo("ssmigrate:%d, vgId:%d, kill ssmigrate request was sent to vnode", req.ssMigrateId, vgId); | ||
| } | ||
|
|
||
| return mndDropSsMigrate(pMnode, pSsMigrate); |
There was a problem hiding this comment.
如果send失了，应该也不执行这dropSsMigrate吧？
xiao-77
approved these changes
Sep 12, 2025
guanshengliang
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implement
show ssmigrateandkill ssmigratecommandChecklist
Please check the items in the checklist if applicable.