Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tao::get overload ambiguity workaround for Cuda10.2 and GCC9.3.1/MSVC2019 #6

Closed
wants to merge 1 commit into from

Conversation

maudoin
Copy link

@maudoin maudoin commented Jul 27, 2020

First, kudos for your nice and clean c++ implementation.
I am currently using Cuda 10.2 (which has bug regarding the std::tuple implementation...) with either gcc9.3.1 and MSVC2019 with c++14 and the samples fails to compile inside a cuda kernel.
Specifying return types to the tao::get methods seems to put too much strain on overloads selection.
This is even worse with Cuda 10.2/MSVC2019 where the move semantic tao::get variant is mixed with other signatures as well. My apologies in advance for the name of the "tao::getMove" function and call I added in the tuple move operator, my first shot at function naming is always bad...
I also fixed two std::move calls that IMHO should be replaced with std::forward.
Best Regards

@d-frey
Copy link
Member

d-frey commented Dec 12, 2020

I just committed another fix for get(), please check if that already solves your problem or if your issue remains.

@d-frey d-frey closed this Aug 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants