Skip to content

More cleanup for Tanya#2

Merged
tanyasmirnova merged 1 commit into
tanyasmirnova:gsl_landstoch_withrucfrom
climbfuji:more_cleanup_for_tanya
Dec 30, 2020
Merged

More cleanup for Tanya#2
tanyasmirnova merged 1 commit into
tanyasmirnova:gsl_landstoch_withrucfrom
climbfuji:more_cleanup_for_tanya

Conversation

@DomHeinzeller
Copy link
Copy Markdown

Cleanup work in lndp_apply_perts.F90: define zs_ruc locally, remove trailing whitespaces, pass only one value lsoil from wrapper.

…railing whitespaces, pass only one value lsoil from wrapper
@DomHeinzeller
Copy link
Copy Markdown
Author

@tanyasmirnova please merge this PR when you get the chance. Thanks!

Copy link
Copy Markdown
Owner

@tanyasmirnova tanyasmirnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dom, we forgot about Noah-MP. Everything that we do for the Noah LSM should work for Noah-MP because it has the same vertical structure in soil domain. Should we add NOah-MP option before merging?

@climbfuji
Copy link
Copy Markdown

Dom, we forgot about Noah-MP. Everything that we do for the Noah LSM should work for Noah-MP because it has the same vertical structure in soil domain. Should we add NOah-MP option before merging?

I wouldn't, honestly. We are not testing it, and untested code is by definition broken.

@tanyasmirnova
Copy link
Copy Markdown
Owner

ok, sounds good. Then I'll merge the code.

@tanyasmirnova tanyasmirnova merged commit 81d091f into tanyasmirnova:gsl_landstoch_withruc Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants