SSH support #2
Open
SSH support #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-tanto
reviewed
Jul 30, 2024
ben-tanto
reviewed
Jul 30, 2024
ben-tanto
reviewed
Jul 30, 2024
| Port uint16 | ||
| } | ||
|
|
||
| func resolveIP(target string) (net.IP, error) { |
There was a problem hiding this comment.
There is an edge case here for IPv6 I think. Line 23: currIp.To4()
./oneshell -s pitest.lan --bypass-ssh-sanity-check
2024/07/30 20:06:55 Port not specified in ssh config, using 22
2024/07/30 20:06:55 Target unspecified, using public IP: <redacted IPv6>
2024/07/30 20:06:55 error occurred when listening: failed to resolve hostname <redacted IPv6>
./oneshell -s pitest.lan
2024/07/30 20:13:41 Port not specified in ssh config, using 22
2024/07/30 20:13:41 Testing connection to SSH server to ensure SSH port forward works...
2024/07/30 20:13:41 Target unspecified, using public IP: <redacted IPv6>
2024/07/30 20:13:41 error occurred when listening: failed to resolve hostname <redacted IPv6>
There was a problem hiding this comment.
This is a good point, however I'm not sure if I want to support IPv6 yet as it would require a fair amount of work changing the assembly code to be able to handle it. I might raise a Github issue for it
There was a problem hiding this comment.
Yes that makes sense. I should have clarified, I believe the issue is that with both IPv4 (private) and IPv6 (public) addresses assigned to my RPI network interfaces it failed. Didn't debug too much but there might be a way to check for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature adds the ability to listen on a port on a remote SSH machine instead of the local machine.