Context.startForegroundService() did not then call Service.startForeground()

[gazedash]

Description

Context.startForegroundService() did not then call Service.startForeground()
#159

Often happens on Samsung, 9.0 android version
I have
<uses-permission android:name="android.permission.FOREGROUND_SERVICE" /> in my manifest.

I use the latest version of react-native-music-control ("0.10.4")

1. Sample code (provide repo url or sample code)

2. Platform ?

   • iOS
   • Android

3. Device

• Simulator
• Real device

[dengue8830]

i'm facing the same, @gazedash do you solve it?

[hiennguyen92]

Got the same issue, I tried many workaround but can't solved completely

[marf]

Same problem here!

[fjmorant]

same 👍

[garfiaslopez]

+1

[benoitvogel]

Same problem here. Android 10 in an emulator.

Crashes consistently when calling setNowPlaying() after either resetNowPlaying() or stopControl().

[bunmiedee]

Turns out that the conditional block in MusicControlNotification onCreate method isn't necessary. You can also replace the conditional block in MusicControlModule with

ContextCompat.startForegroundService(context, myIntent);

In MusicControlNotification Replace with:

public void onCreate() {
            super.onCreate();
            notification = MusicControlModule.INSTANCE.notification.prepareNotification(MusicControlModule.INSTANCE.nb, false);
            startForeground(NOTIFICATION_ID, notification);
            isRunning = true;
        }

[tanguyantoine]

reproducible with 0.10.8?

[zatloeri]

reproducible with 0.10.8?

@tanguyantoine Yes, still getting this error on some hw devices in 0.10.8.
It started happening after I started calling resetNowPlaying() or stopControl() shortly after app start.

[pabloluz]

Same issue here. I'm on 0.11.0.

[pabloluz]

(Just realized many currently open issues might be related to this one, like #244, for example)

@tanguyantoine, I appreciate in advance your attention on that ;)

[tanguyantoine]

@bunmiedee would you mind creating a pull request ?

[bunmiedee]

@tanguyantoine sure - I can look into it over the weekend

[sparcbr]

While we don't fix this I'm using this workaround to prevent multiple calls to startForegroundService. Seems to stop the bug from happening.

I just commented out all the code that unregisters and releases eveything, preventing init() from running more than once.

--- a/android/src/main/java/com/tanguyantoine/react/MusicControlModule.java
+++ b/android/src/main/java/com/tanguyantoine/react/MusicControlModule.java
@@ -35,6 +35,7 @@ import java.net.URLConnection;
 import java.util.HashMap;
 import java.util.Locale;
 import java.util.Map;
+import androidx.core.content.ContextCompat;
 
 public class MusicControlModule extends ReactContextBaseJavaModule implements ComponentCallbacks2 {
     private static final String TAG = MusicControlModule.class.getSimpleName();
@@ -198,12 +199,7 @@ public class MusicControlModule extends ReactContextBaseJavaModule implements Co
 
         afListener = new MusicControlAudioFocusListener(context, emitter, volume);
 
-        if(Build.VERSION.SDK_INT >= Build.VERSION_CODES.O){
-            context.startForegroundService(myIntent);
-
-        }
-        else
-            context.startService(myIntent);
+        ContextCompat.startForegroundService(context, myIntent);
 
         context.registerComponentCallbacks(this);
 
@@ -218,6 +214,10 @@ public class MusicControlModule extends ReactContextBaseJavaModule implements Co
 
         if (notification != null)
             notification.hide();
+
+        session.setActive(false);
+
+                /*
         session.release();
 
         ReactApplicationContext context = getReactApplicationContext();
@@ -239,6 +239,7 @@ public class MusicControlModule extends ReactContextBaseJavaModule implements Co
         nb = null;
 
         init = false;
+                */
     }
 
     synchronized public void destroy() {

[bradfloodx]

This was a problem for me too. Reopening to be fixed.

PRs welcome! @sparcbr @bunmiedee @pabloluz @gazedash

[bradfloodx]

Should be fixed in #329

[rborn]

@bradleyflood @bunmiedee I still get this (a lot) with the latest version 😔

[rborn]

@bradleyflood @bunmiedee I'll try this fix and make a PR if it works https://stackoverflow.com/a/53402038, it will take a while because I cannot reproduce on any of my devices so I need to push to prod 🙄

[bradfloodx]

Thanks @rborn I'll reopen this issue.

[rborn]

Just a heads-up, the above "fix" didn't work, we still have a lot of crashes on android 9/10 :(

[hiroyaiizuka]

any updates?
still get this error ...😣

[rborn]

@SBShane cold call I know 😅 but I see you are versed with android ? any chance you could look into this ? 😻

[rborn]

@SBShane I found this fork, will let you know if I can merge to mine and if it works - https://github.com/natashache/react-native-music-control

[rborn]

Small update: we launched to prod with the changes done using the above fork and it seems to be fixed. I'll like to a few more days to be sure.

@natashache I have my fork where I merged your code 😻, synced with current master and added a small fix. Would you like to make a PR or can I do it? 😻 https://github.com/rborn/react-native-music-control

[rborn]

@bradleyflood I have been testing the fix in production and it seems to work fine, however I got no reply from @natashache nor @hiennguyen92 (natashache@c28a931#commitcomment-41838029) so I don't know how to proceed :(

[hiennguyen92]

@rborn You are free to use it at your disposal.

[rborn]

@hiennguyen92 thank you, I'll create a PR soon 😻

[rborn]

@bradleyflood PR done, can we maybe have a release 😅 ? This code is tested in production, we got no errors related to the startForeground anymore (there are some commits after that, which fix small issues but the crashes were only a few)

@hiennguyen92, @natashache thank you for your fixes 😻

[bradfloodx]

Thanks Dan. Let me check it out and get back to you. Brad

…

On Tue, 8 Sep 2020 at 19:14, Dan Tamas ***@***.***> wrote: @bradleyflood <https://github.com/bradleyflood> PR done, can we maybe have a release 😅 ? This code is tested in production, we got no errors related to the startForeground anymore (there are some commits after that, which fix small issues but the crashes were only a few) @hiennguyen92 <https://github.com/hiennguyen92>, @natashache <https://github.com/natashache> thank you for your fixes 😻 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#266 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIJEGCK77PR2U5HA7VY43TSEXYXPANCNFSM4HVBOGGQ> .