Skip to content

Conversation

@1xstj
Copy link
Contributor

@1xstj 1xstj commented Feb 7, 2023

Summary of changes
Changes introduced in this pull request:

  • Remove transactional macro
  • Handle all unsafe arithmetic and unwrap()
  • Fix all failing benchmarks
  • Add benchmark check to CI
  • Add taplo config to format toml files

Reference issue to close (if applicable)
Closes #283

@drewstone
Copy link
Contributor

CI failing here @1xstj

@1xstj 1xstj marked this pull request as ready for review February 9, 2023 13:20
Copy link
Contributor

@drewstone drewstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have inconsistent spacing in the Cargo.toml files, some using 4 spaces, some using tabs, some using 2 spaces.

@drewstone drewstone merged commit 651b202 into main Feb 22, 2023
@drewstone drewstone deleted the sbp-fixes-round-2 branch February 22, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants