Skip to content

Conversation

@1xstj
Copy link
Contributor

@1xstj 1xstj commented Jan 10, 2023

Summary of changes
Changes introduced in this pull request:

  • remove without_storage_info from runtime
  • replace all Vec<> with BoundedVec<> in runtime
  • Add call indices for all pallets

Reference issue to close (if applicable)
Part of SBP Review #283
Also closes #286

@1xstj 1xstj requested review from drewstone and shekohex January 12, 2023 20:11
@1xstj 1xstj marked this pull request as ready for review January 12, 2023 20:11
@drewstone drewstone merged commit b5ca20e into main Jan 13, 2023
@drewstone drewstone deleted the 1xstj/sbp-fixes branch January 13, 2023 00:22
@drewstone
Copy link
Contributor

Addresses #283

),
Error::<Test>::TooLong
);
// assert_noop!(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@1xstj can we remove these if they're meant to be commented out in a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Depreciation warnings

3 participants