Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use relative templates paths in views so that projects can extend them #2

Open
wants to merge 1 commit into
base: release/0.1
Choose a base branch
from

Conversation

costas-basdekis
Copy link
Contributor

No description provided.

@codeinthehole
Copy link
Contributor

They were relative to start with. Can't you just have a oscar_approval/ folder in your template directory to override them?

@costas-basdekis
Copy link
Contributor Author

In case I want to change only a part of the template, I will have to copy the whole template in my project. I see a couple of issues with this practice:

  1. My project won't benefit from any fixes/updates in that template
  2. I can't reason about the copied template: there is no commit history, and it's not immediate obvious why is it there, and what was changed
  3. In case I want to update to a new version of django-oscar-approval I will have to do a diff with the template of the old version to find out what did I change
  4. It doesn't follow the convention of linking to the 'app/page/template.html', and storing the template in 'module/app/page/template.hmtl', like Oscar does

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants