Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use the zstyle configuration #24

Merged
merged 2 commits into from
Jul 19, 2022
Merged

Update to use the zstyle configuration #24

merged 2 commits into from
Jul 19, 2022

Conversation

jnooree
Copy link
Contributor

@jnooree jnooree commented Jul 19, 2022

Upstream switched to the zstyle-based configuration on ohmyzsh/ohmyzsh@3c97433.

This PR will bring the introduced change into this repository.

@tamcore
Copy link
Owner

tamcore commented Jul 19, 2022

Thank you for your contribution!

Generally looks good to me. But could you please have another look at the indentation? If you could replace the tabs with whitespaces, I'll gladly merge it :) I've just added a pre-commit config. So pre-commit run --all-files should be able to take care of most of it :)

jnooree added 2 commits July 19, 2022 14:58
@jnooree
Copy link
Contributor Author

jnooree commented Jul 19, 2022

Fixed in jnooree@8c912ad54faca0fe6f87aa727f513311d52c6d17. Thanks for your review!

@tamcore tamcore merged commit 4bad56f into tamcore:master Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants