Upgrade at will #11
Merged
Upgrade at will #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, one could only use this plugin when the automatic ZSH update days configuration value triggered the time check, so at most once a day. This commit makes the core function _upgrade_custom public and changes its name to upgrade_oh_my_zsh_custom. This way, one may check for updates as regularly as desired, while keeping the time trigger active. Also, the chosen name is not too far from the OhMyZsh upgrade function. Signed-off-by: Paul Mabileau <[email protected]>
This commit introduces a small alias that enables one to run the OhMyZsh, custom plugins and custom themes in one go. It is called upgrade_ohl_my_zsh in order to be even closer to the OhMyZsh upgrade function's name, while still making sort of a sense: 'ohl' = 'all'. Signed-off-by: Paul Mabileau <[email protected]>
This adds a small description of the added functionalities to the README. Signed-off-by: Paul Mabileau <[email protected]>
|
@PositivePaulo Thank you for this contribution! Me merging another PR introduced merge conflicts here. Would you be so kind to resolve them? I'll merge this PR then as well :) |
|
@tamcore You are most welcome! Obviously I did this for my own benefit as well, but I am glad it can be shared. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the only way to run the upgrade of the custom themes and plugins is
to let time pass so the time check may be triggered by the UPDATE_ZSH_DAYS
configuration variable's delay. As it is in days only, one may run the upgrade
every day at most, which is sufficient really, but if an upgrade fails for whatever
reason, then it would convenient to do it again right after.
Therefore, two small modifications are proposed here:
The first one is the most important one, while the second is proposed in order
to complete it further so it can be a bit more convenient. The names used may
be subject to discussion of course. Let me know your opinion.
I am not really able to test if it is 100% compatible with all types of configuration
neither if it is usable outside of a loaded OhMyZsh environment, but I don't
know if that is even possible. So could you guide me in this regard ?
Thanks in advance.