Skip to content

Toggle grayscale of all videos using "Toggle Grayscale" button #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2023

Conversation

roomrys
Copy link
Collaborator

@roomrys roomrys commented Mar 9, 2023

Description

Previous the "Toggle Grayscale" button in the GUI toggled the grayscale of videos on a video-by-video basis. However, this does not make sense since all projects (at the current SLEAP state) need to be either grayscale projects or color projects (see: #759). This PR broadens the functionality of the "Toggle Grayscale" button to toggle all videos to grayscale/color at once

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (explain)

Does this address any currently open issues?

[list open issues here]

Outside contributors checklist

  • Review the guidelines for contributing to this repository
  • Read and sign the CLA and add yourself to the authors list
  • Make sure you are making a pull request against the develop branch (not main). Also you should start your branch off develop
  • Add tests that prove your fix is effective or that your feature works
  • Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP!

❤️

@codecov
Copy link

codecov bot commented Mar 9, 2023

Codecov Report

Merging #1215 (b2ddca3) into develop (4bd0171) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop    #1215      +/-   ##
===========================================
- Coverage    72.13%   72.11%   -0.02%     
===========================================
  Files          132      132              
  Lines        23526    23535       +9     
===========================================
+ Hits         16971    16973       +2     
- Misses        6555     6562       +7     
Impacted Files Coverage Δ
sleap/gui/commands.py 60.63% <50.00%> (-0.23%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@roomrys roomrys marked this pull request as ready for review March 15, 2023 23:28
@roomrys roomrys requested a review from talmo March 15, 2023 23:28
@roomrys roomrys merged commit 931791b into develop Mar 20, 2023
@roomrys roomrys deleted the liezl/toggle-grayscale-all branch March 20, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants