coderabbit suggestion for division by zero error, cache_property and …

…attr default

sleap/nn/inference.py

@@ -48,8 +48,12 @@
 
 if sys.version_info >= (3, 8):
     from functools import cached_property
-else:  # cached_property is define only for python >=3.8
-    cached_property = property
+
+else:  # cached_property is defined only for python >=3.8
+    from functools import lru_cache
+
+    def cached_property(func):
+        return property(lru_cache()(func))
 
 import tensorflow as tf
 import numpy as np
@@ -164,6 +168,8 @@ class Predictor(ABC):
     @cached_property
     def report_period(self) -> float:
         """Time between progress reports in seconds."""
+        if self.report_rate <= 0:
+            raise ValueError("report_rate must be positive")
         return 1.0 / self.report_rate
 
     @classmethod

sleap/nn/tracking.py

@@ -1,6 +1,7 @@
 """Tracking tools for linking grouped instances over time."""
 
 import abc
+import functools
 import json
 import sys
 from collections import deque
@@ -35,8 +36,12 @@
 
 if sys.version_info >= (3, 8):
     from functools import cached_property
-else:  # cached_property is define only for python >=3.8
-    cached_property = property
+
+else:  # cached_property is defined only for python >=3.8
+    from functools import lru_cache
+
+    def cached_property(func):
+        return property(lru_cache()(func))
 
 
 @attr.s(eq=False, slots=True, auto_attribs=True)
@@ -519,8 +524,12 @@ def get_candidates(
 class BaseTracker(abc.ABC):
     """Abstract base class for tracker."""
 
-    verbosity: str
-    report_rate: float
+    verbosity: str = attr.ib(
+        validator=attr.validators.in_(["none", "rich", "json"]),
+        default="none",
+        kw_only=True,
+    )
+    report_rate: float = attr.ib(default=2.0, kw_only=True)
 
     @property
     def is_valid(self):
@@ -529,6 +538,8 @@ def is_valid(self):
     @cached_property
     def report_period(self) -> float:
         """Time between progress reports in seconds."""
+        if self.report_rate <= 0:
+            raise ValueError("report_rate must be positive")
         return 1.0 / self.report_rate
 
     def run_step(self, lf: LabeledFrame) -> LabeledFrame:
@@ -751,12 +762,6 @@ class Tracker(BaseTracker):
 
     last_matches: Optional[FrameMatches] = None
 
-    verbosity: str = attr.ib(
-        validator=attr.validators.in_(["none", "rich", "json"]),
-        default="none",
-    )
-    report_rate: float = 2.0
-
     @property
     def is_valid(self):
         return self.similarity_function is not None
@@ -1493,12 +1498,6 @@ class KalmanTracker(BaseTracker):
     last_t: int = 0
     last_init_t: int = 0
 
-    verbosity: str = attr.ib(
-        validator=attr.validators.in_(["none", "rich", "json"]),
-        default="none",
-    )
-    report_rate: float = 2.0
-
     @property
     def is_valid(self):
         """Do we have everything we need to run tracking?"""