Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests and functionality for loading provenance data #14

Merged
merged 3 commits into from
Sep 13, 2022

Conversation

h-mayorquin
Copy link
Contributor

Description

This PR adds the functionality for loading the provenance data to a Labels object. Most of it was already in place and there was just the initialization missing.

I also added a test. As the old data fixtures did not seem to contain provenance data (they have empty dicts) I also generated some fixture by running your software latest version in your training data tutorial. This maybe should be changed as I don't know what's your policy for adding fixtures and this was meant to be temporal.

Types of changes

  • Bugfix
  • New feature
  • Refactor / Code style update (no logical changes)
  • Build / CI changes
  • Documentation Update
  • Other (explain)

Does this address any currently open issues?

No

Outside contributors checklist

  • Review the guidelines for contributing to this repository
  • Add tests that prove your fix is effective or that your feature works
  • Add necessary documentation (if appropriate)

Thank you for contributing to SLEAP-IO!

❤️

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #14 (1585a9d) into main (00c2125) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          515       517    +2     
=========================================
+ Hits           515       517    +2     
Impacted Files Coverage Δ
sleap_io/io/slp.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@talmo talmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also looks good to me! Policy for adding fixtures is to keep it to a minimum, but this PR is quite helpful actually -- thanks!

@talmo talmo merged commit a309af4 into talmolab:main Sep 13, 2022
@h-mayorquin h-mayorquin deleted the add_provenance branch September 13, 2022 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants