Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gcloud): Support publishing packages to GCP Artifact Registry #47

Merged
merged 7 commits into from
Jun 7, 2021
Merged

feat(gcloud): Support publishing packages to GCP Artifact Registry #47

merged 7 commits into from
Jun 7, 2021

Conversation

caseydialpad
Copy link
Contributor

Summary

This PR adds support for publishing packages to GCP's Artifact Registry [Python] Package Repository.

Checklist

  • My comments/docstrings/type hints are clear
  • I've written new tests or this change does not need them
  • I've tested this manually
  • The architecture diagrams have been updated, if need be
  • I've included any special rollback strategies above
  • Any relevant metrics/monitors/SLOs have been added or modified
  • I've notified all relevant stakeholders of the change

@caseydialpad caseydialpad requested a review from TheKevJames as a code owner June 4, 2021 18:32
@caseydialpad caseydialpad requested review from a team and shaundialpad and removed request for a team June 4, 2021 18:32
@caseydialpad caseydialpad reopened this Jun 4, 2021
TheKevJames
TheKevJames reviewed Jun 4, 2021
View reviewed changes
gcloud/orb.yaml Outdated Show resolved Hide resolved
TheKevJames
TheKevJames requested changes Jun 4, 2021
View reviewed changes
gcloud/orb.yaml Outdated Show resolved Hide resolved
gcloud/orb.yaml Outdated Show resolved Hide resolved
gcloud/orb.yaml Outdated Show resolved Hide resolved
gcloud/orb.yaml Outdated Show resolved Hide resolved
TheKevJames
TheKevJames approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@TheKevJames TheKevJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@caseydialpad caseydialpad merged commit d05bf63 into master Jun 7, 2021
@caseydialpad caseydialpad deleted the cph/artifact-package-publish branch June 7, 2021 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheKevJames TheKevJames TheKevJames approved these changes

@shaundialpad shaundialpad Awaiting requested review from shaundialpad

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caseydialpad @TheKevJames