Skip to content

Fix routing for vite prefix on dev vs build #319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 27, 2025
Merged

Fix routing for vite prefix on dev vs build #319

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4803b2a
Fix routing for vite prefix on dev vs build
StealthBadger747 Sep 27, 2025
65f5684
Merge branch 'next' into erikp/fix-vite-dev-path
StealthBadger747 Sep 27, 2025
cee28fb
Update nix stuff
StealthBadger747 Sep 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions flake.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 23 additions & 1 deletion flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,29 @@ rec {
"x86_64-linux"
]
(system: let
# Overlay: bump go_1_25 to 1.25.1 while nixpkgs-unstable lags behind
# https://nixpk.gs/pr-tracker.html?pr=441125 / https://github.com/NixOS/nixpkgs/pull/441125
# https://github.com/NixOS/nixpkgs/issues/440982
go1251Overlay = (final: prev:
let
newVersion = "1.25.1";
in {
go_1_25 = prev.go_1_25.overrideAttrs (old: {
version = newVersion;
src = prev.fetchurl {
url = "https://go.dev/dl/go${newVersion}.src.tar.gz";
hash = "sha256-0BDBCc7pTYDv5oHqtGvepJGskGv0ZYPDLp8NuwvRpZQ=";
};
});
# ensure pkgs.go resolves to the bumped compiler
go = final.go_1_25;
});
pkgs = import nixpkgs {
inherit system;
overlays = [devshell.overlays.default];
overlays = [
devshell.overlays.default
go1251Overlay
];
};
in rec {
formatter = pkgs.alejandra;
Expand Down Expand Up @@ -57,6 +77,8 @@ rec {
pkgs.nodejs-slim_22
pkgs.pnpm_10
pkgs.typescript-language-server
pkgs.mise
pkgs.mkcert
];
env = [];
};
Expand Down
4 changes: 2 additions & 2 deletions vite.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ if (!version) {
const config = await readFile('config.example.yaml', 'utf-8');
const { server } = parse(config);

export default defineConfig(({ mode, isSsrBuild }) => ({
base: mode !== 'development' ? `${prefix}/` : undefined,
export default defineConfig(({ command, isSsrBuild }) => ({
base: command === 'build' ? `${prefix}/` : undefined,
plugins: [
reactRouterHonoServer(),
reactRouter(),
Expand Down
Loading