[next] Re-Implement optional paths in the config loader #283
Conversation
| exclude: ['node_modules/**', 'build/**'], | ||
| setupFiles: ['./tests/setupOverlayFs.js'], | ||
| }, | ||
| resolve: { |
There was a problem hiding this comment.
Any chance this can "just work" with vite and the tsconfigPaths plugin?
There was a problem hiding this comment.
I can probably play around with it and see. There was a reason why I did it, but it's possible it's not needed anymore.
|
Overall this is very solid stuff, once you address the review I'll merge this in and then Nix 🔥 |
|
@StealthBadger747 You can drop these Nix commits as I've extracted them into: #282: Also, you can drop the After that the PR will have only TypeScript changes. |
|
Ah, the nix stuff snuck in 😅, I made this PR while jet lagged. I'll clean it up later today |
Got the build working Maybe actually fix builds Copy drizzle as well
Revert flake.nix and package.nix to main; drop wasm.nix
StealthBadger747
force-pushed
the
erikp/implement-path-loading-round-2
branch
from
16e549a to
d7e62bd
Compare
|
Unfortunately I do not have time to play around with |
|
That's ok, I'll merge it in for now |
Add File-Based Configuration Support
This PR adds support for loading sensitive configuration values from files, improving security and integration with system credential management.
Changes
*_pathvariables for sensitive configuration values:pre_authkey_path,client_secret_path,headscale_api_key_path,cookie_secret_path,Testing
Added test suite in
tests/config.test.jsto verify the new configuration system.Differences vs #213
I think is is a much simpler implementation, less changes to the arktype structures and less supporting code and other weirdness.
Tagging @igor-ramazanov