feat: add kubernetes deployment configuration using helm #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: jcstryker <[email protected]>
Open
|
For reference I added some stuff on top of @antoniolago's repo here I only was trying to get things working, use my changes however you would like or not at all :) |
Signed-off-by: jcstryker <[email protected]>
Signed-off-by: jcstryker <[email protected]>
Signed-off-by: jcstryker <[email protected]>
Signed-off-by: jcstryker <[email protected]>
Signed-off-by: jcstryker <[email protected]>
This commit removes the unused PersistentVolumeClaim templates for headplane and headscale components. The templates were left in place but contained only a TODO comment, indicating they were not yet implemented. Removing them cleans up the codebase and prevents confusion about their intended purpose. The pvc templates were previously defined in the kubernetes/headplane/templates/headplane/pvc.yaml and kubernetes/headplane/templates/headscale/pvc.yaml files but were not actually needed for the current implementation. This change reduces code clutter and improves maintainability by removing dead code. Signed-off-by: jcstryker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative Helm chart to the chart provided here https://github.com/nbcloudio/headplane-chart
@antoniolago did some fantastic work updating that chart, though I have some concerns around best practices and security - feeling it best to start from scratch.
Provided to this project under the MIT licence.