Proc mode: try to guess PID based on Parent PID when multiple found #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm open to this change, but what are the consequences of the bad case, where the PID is not correctly found based on the PID 1 heuristic? |
|
If it finds no PID with Parent PID 1 it fails like it did before. If it finds one and that is somehow the wrong one it won't work. Its the assumption that if it is spawned by PID 1, aka "init", it is the root one. |
|
Sounds good, will merge this in for the 0.6.1 candidate. |
|
As one of the people hit by this, I'm interested in trying out 6.1 one this is merged in 🙂. |
|
I'm going to merge this in and do a formatting pass on it. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headplane seems to have problem when there are multiple PIDs that has the same cmdline.
The correct PID is the one with Parent PID 1 which is the one spawned by systemd.
This is not always the case, but I see this as a better solution than erroring out if count > 1.