Implement Parquet Support For Egress Pipeline Output #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelindar
requested changes
May 7, 2021
internal/encoding/parquet/parquet.go
Outdated
| } | ||
| } | ||
| return result | ||
| } | ||
|
|
||
| func getSchemaLogicalType(t *parquet.LogicalType) parquet.Type { |
There was a problem hiding this comment.
Rename getSchemaLogicalType -> parquetTypeOf(c *goparquet.Column), also add a comment.
First thing, check if it's supported here so you can remove the code above:
func parquetTypeOf(c Column) parquet.Type {
if t, supported := typeof.FromParquet(c.Type()); supported {
return t
}
... existing switch
}
There was a problem hiding this comment.
Actually, this function isnt really doing the actual check. It is only getting the logical type of the column if the physical type is not set since the logical type does not directly map to a physical type.
|
@kelindar Updated, please see |
kelindar
requested changes
May 10, 2021
|
@kelindar Fixed, please see |
kelindar
requested changes
May 11, 2021
|
@kelindar Updated, please see |
kelindar
requested changes
May 12, 2021
|
@kelindar Done, pleass see |
kelindar
requested changes
May 13, 2021
|
@kelindar Apologies, I missed your last comment. Have fixed it now. |
kelindar
approved these changes
May 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit also fixes a bug in parquet read support which did not allow strings to be processed correctly