-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Parquet Support For Egress Pipeline Output #67
Conversation
internal/encoding/parquet/parquet.go
Outdated
} | ||
} | ||
return result | ||
} | ||
|
||
func getSchemaLogicalType(t *parquet.LogicalType) parquet.Type { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename getSchemaLogicalType
-> parquetTypeOf(c *goparquet.Column)
, also add a comment.
First thing, check if it's supported here so you can remove the code above:
func parquetTypeOf(c Column) parquet.Type {
if t, supported := typeof.FromParquet(c.Type()); supported {
return t
}
... existing switch
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, this function isnt really doing the actual check. It is only getting the logical type of the column if the physical type is not set since the logical type does not directly map to a physical type.
@kelindar Updated, please see |
@kelindar Fixed, please see |
@kelindar Updated, please see |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes left, almost there.
@kelindar Done, pleass see |
@kelindar Apologies, I missed your last comment. Have fixed it now. |
This commit also fixes a bug in parquet read support which did not allow strings to be processed correctly