Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NewMultiAccountWriter for azure sink #66

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Add NewMultiAccountWriter for azure sink #66

merged 1 commit into from
Apr 22, 2021

Conversation

qiaowei-g
Copy link
Collaborator

  1. Add Azure Multi Storage Account Writer, use Azure AD credential for authentication.
  2. Change multi.writer to call writers in parallel.
  3. Add Datadog metric for writer latency and error stats.

@qiaowei-g qiaowei-g force-pushed the azure-multi-pr branch 2 times, most recently from 2a5ee11 to 0c9756b Compare April 22, 2021 05:00
kelindar
kelindar approved these changes Apr 22, 2021
View reviewed changes
Copy link
Collaborator

@kelindar kelindar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, @qiaowei-g this is very good

@kelindar kelindar merged commit b84ed6d into master Apr 22, 2021
@kelindar kelindar deleted the azure-multi-pr branch April 22, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kelindar kelindar kelindar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qiaowei-g @kelindar