Update compression method and expose badger options #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
a9kitkumarsinha
commented
Jun 11, 2020
•
a9kitkumarsinha
commented
- Use zlip compression
- Expose badger options as
- Add statsd metrics for
- Keys addes
- Keys deleted
- Compaction latency
- Delete key latency
a9kitkumarsinha
changed the title
kelindar
requested changes
Jun 29, 2020
internal/config/config.go
Outdated
| MaxTableSize *int64 `json:"maxTableSize" yaml:"maxTableSize" env:"MAXTABLESIZE"` // maximum size in bytes for each LSM table or file. | ||
| LevelOneSize *int64 `json:"levelOneSize" yaml:"levelOneSize" env:"LEVELONESIZE"` // maximum total size in bytes for Level 1. defaults to 1 Million | ||
| LevelSizeMultiplier *int `json:"levelSizeMultiplier" yaml:"levelSizeMultiplier" env:"LEVELSIZEMULTIPLIER"` // the ratio between the maximum sizes of contiguous levels in the LSM. defaults to 10 | ||
| MaxLevels *int `json:"maxLevels" yaml:"maxLevels" env:"MAXLEVELS"` // maximum number of levels of compaction allowed in the LSM. defaults to 7 |
There was a problem hiding this comment.
Can we add something like
Defaults string `json:"defaults" yaml:"defaults" env:"DEFAULTS"`
which would essentially be one of 3 possible values badger, ingestion, storage and switch either badger.DefaultOptions(dir) or 2 other sets of constant values.
I know it's making it a bit specific for our use-cases, but I'd rather not loose the track of the tuned parameters we have and we can interate from here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.