Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a compact before close #30

Merged
merged 4 commits into from
Jun 10, 2020
Merged

Add a compact before close #30

merged 4 commits into from
Jun 10, 2020

Conversation

a9kitkumarsinha
Copy link
Collaborator

  1. Add a final flush before close to drain all the data before the instance terminate

s.merge(merged, blocks, schema)
} else {
// Merge asynchronously and delete the keys on a successful merge
queue <- s.mergeTask(merged, blocks, schema)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's always have merge which returns the Task (as before), but instead

task := s.merge(merged, blocks, schema)
queue <- task
if sync {
    task.Outcome() // Wait
}

@kelindar kelindar merged commit 565435b into master Jun 10, 2020
@kelindar kelindar deleted the flush-before-close branch June 10, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants