Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix graceful shutdown #110

Merged
merged 6 commits into from
Jul 12, 2022
Merged

Fix graceful shutdown #110

merged 6 commits into from
Jul 12, 2022

Conversation

atlas-comstock
Copy link
Collaborator

No description provided.

@atlas-comstock atlas-comstock force-pushed the fix-graceful-shutdown branch from 791e574 to 7f3b1b4 Compare July 4, 2022 09:24
@atlas-comstock
Copy link
Collaborator Author

And I add more logs so that we can know what happens and how long it takes

^C2022/07/04 17:33:21 received signal interrupt, start graceful shutdown
2022/07/04 17:33:21 Cancel ctx done
2022/07/04 17:33:21 Close gossip done
2022/07/04 17:33:21 server: wait exit...
2022/07/04 17:33:21 GRPC GracefulStop done, it will wait all request finished
2022/07/04 17:33:21 Close table nodes done, it will compact all if compact is enable
2022/07/04 17:33:21 Close table logs done, it will compact all if compact is enable
2022/07/04 17:33:21 Compact start closing, will compact all data
2022/07/04 17:33:22 Compact finshed
2022/07/04 17:33:22 Close table eventlog done, it will compact all if compact is enable
2022/07/04 17:33:22 Graceful shutdown finished, ready to exit
2022/07/04 17:33:22 server: exit after ctx is done...

@atlas-comstock atlas-comstock marked this pull request as ready for review July 4, 2022 09:39
@atlas-comstock atlas-comstock force-pushed the fix-graceful-shutdown branch from 7f3b1b4 to 4e77ac4 Compare July 4, 2022 10:23
@tardunge
Copy link
Collaborator

tardunge commented Jul 5, 2022

LGTM.

@atlas-comstock
Copy link
Collaborator Author

@tardunge Let me finish the testing on my stg env first, as I had updated docker image too.

@atlas-comstock
Copy link
Collaborator Author

@tardunge @kelindar tested on stg ENV, LGTM

@tardunge
Copy link
Collaborator

tardunge commented Jul 6, 2022

Can you fix the tests?

@atlas-comstock
Copy link
Collaborator Author

@tardunge fixed, overlook the tests.

@atlas-comstock
Copy link
Collaborator Author

Oh, plz wait. I met a issue about environment variable not passed to process

tardunge
tardunge approved these changes Jul 6, 2022
View reviewed changes
@tardunge tardunge self-requested a review July 6, 2022 10:04
@atlas-comstock atlas-comstock force-pushed the fix-graceful-shutdown branch from 0f47c97 to 5d34c76 Compare July 7, 2022 03:53
@atlas-comstock atlas-comstock merged commit 618c3f2 into talariadb:master Jul 12, 2022
@atlas-comstock
Copy link
Collaborator Author

@tardunge Validated in our STG and PRD, could try this in your service as well.

This was referenced Oct 13, 2022
Closed
Closed
tardunge
tardunge reviewed Oct 13, 2022
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tardunge tardunge tardunge approved these changes

@kelindar kelindar Awaiting requested review from kelindar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atlas-comstock @tardunge @hiohiograb