add tables field to ingest grpc contract #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jeffreylean
commented
Jun 28, 2022
jeffreylean
commented
- Add console writer for debugging purposes
- Change ingest_server gRPC contract by adding a new field called tables, in order to support specific table destination(s) while ingesting the batch
|
@jeffreylean @kelindar @tardunge |
|
yes, agreed. This makes much more sense. |
|
LGTM |
Sure, let me review it today, should be fine |
|
LGTM |
atlas-comstock
changed the title
|
@tardunge @jeffreylean btw, you are using https://pkg.go.dev/time#Time.UnixMicro which is only supported from 1.17 so that I upgrade the github ci go version. |
|
I faced a similar issue with UnixNano btwn. Time to bump version to 1.18? |
|
haha, can. Now it is 1.17. @tardunge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.