Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 3.2 support, remove DoS vector #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

oggy
Copy link

@oggy oggy commented Jun 27, 2012

Hi,

Just added Rails 3.2 support in our branch.

Also removed a potential denial of service vector. Since symbols aren't garbage collected, it's important that we don't simply call #intern / #to_sym on the given value when casting, else malicious user input could in theory fill up the symbol table. Here, I simply maintain a hash of allowed values, so casting simply boils down to a Hash lookup.

Let me know what you think.

Thanks for your work on this!
George

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant