feat(tms): 設定メニューの表示モード #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: cffnpwr <[email protected]>
taiyme
force-pushed
the
non-grid-settings-menu
branch
from
76a1bba to
159aa56
Compare
|
コンフリクト解消のためにmergeしたら馬鹿みたいに変更量があって脳が破壊されたので、再度書き直してforce pushしました❗❗❗❗❗Draftに戻します❗❗❗❗❗❗❗❗❗❗ |
taiyme
reviewed
Mar 7, 2024
| <button | ||
| v-else-if="item.type === 'button'" | ||
| :key="`group:${i}-button:${j}`" | ||
| tabindex="0" |
taiyme
reviewed
Mar 7, 2024
| def: any[]; | ||
| grid?: boolean; | ||
| def: SuperMenuDef; | ||
| wideMode?: boolean; |
There was a problem hiding this comment.
必ずしもgridで描画されるわけではないので、wideであることを伝えるpropsにする
taiyme
approved these changes
Mar 7, 2024
1673beta
pushed a commit
to bettaku/taiyme_shinano_fork
that referenced
this pull request
Oct 18, 2024
…ge-generic Merge 2024.9.0 to releases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
スマホUIのときに設定メニューをグリッドではなくリスト表示にする
Why
https://submarin.online/notes/9owxk2k3ts
Additional info (optional)
Checklist