Resource system partial refactor #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames some functions for consistency, but more importantly completely redesigns resource lifetime management.
RESF_PERMANENTis gone and resources are now reference-counted. Preload functions now require aResourceGroupobject that keeps references to the preloaded resources.ResourceGroups must be eventuallyres_group_release()'d, which decrements the refcounts of previously preloaded resources and frees memory used to store the references. Resources with zero refcount are not unloaded immediately, but put in a "purgatory" list instead.res_purge()can be called to unload all resources currently in the purgatory. Currently a purge is done right after preloading resources for a stage. This lets us keep shared resources loaded across stages, while unloading the no longer needed ones.Resources that weren't preloaded are put into an implicit global
ResourceGroup, which is never released until exit. This still generates a warning at runtime. It is possible to put resources into this global group manually without triggering the warning by passingNULLfor the group pointer tores_group_preload(), but it's recommended to manage a localResourceGroupinstead.