-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Story/Dialogue Edits #361
Story/Dialogue Edits #361
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preliminary review skimming through the diff. I'll take a closer look in-game later.
src/dialog/marisa.c
Outdated
@@ -459,6 +465,7 @@ DIALOG_TASK(marisa, Stage5PreBoss) { | |||
|
|||
MSG(iku, "Enough!"); | |||
MSG(iku, "It is said that specifically applied electro-stimulation can ease the mind."); | |||
FACE(iku, eyes_closed); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation gone wrong here?
src/dialog/reimu.c
Outdated
@@ -339,11 +339,12 @@ DIALOG_TASK(reimu, Stage4PreBoss) { | |||
MSG(reimu, "I can’t stand scratchy wool or slippery silk!"); | |||
MSG(reimu, "Everything else feels terrible again my skin—"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo here (in the original too)
MSG(reimu, "Everything else feels terrible again my skin—"); | |
MSG(reimu, "Everything else feels terrible against my skin—"); |
|
||
FACE(kurumi, defeated); | ||
MSG(kurumi, "Huh? I-I don’t know! I barely remember anything!"); | ||
MSG(kurumi, "(Ugh, her clothes really do suck though…)"); | ||
MSG(kurumi, "(Ugh, her outfit really does suck though…)"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just wanna use this opportunity to point out that Taisei Kurumi has objectively the worst taste in fashion.
src/dialog/youmu.c
Outdated
MSG(kurumi, "Of course not! Who do you take me for?!"); | ||
MSG(kurumi, "No WAY I’d want to associate myself with the folk of this mansion!"); | ||
MSG(kurumi, "No WAY I’d want to associate myself with the people running this mansion!"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feels too neutral. How about "the dorks running this place"?
src/dialog/marisa.c
Outdated
|
||
EVENT(boss_appears); | ||
WAIT(60); | ||
MSG_UNSKIPPABLE(hina, 180, "Why hello, Ms. Kirisame."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am generally not a fan of MSG_UNSKIPPABLE
. In this kind of game you'll be replaying the same stages hundreds of times, so skipping through the dialogue should be easy and near instantaneous.
I only know of one instance where a MSG_UNSKIPPABLE
is justified: the 2-second line post midboss in stage 5. It's needed there to keep the music in sync.
The same applies to WAIT
; it should be replaced with WAIT_SKIPPABLE
in dialogue code unless the delay is absolutely necessary (why?).
Can you please try converting everything else into regular skippable messages, and let me know if that breaks anything when fast-forwarding through the whole dialogue?
src/dialog/reimu.c
Outdated
@@ -61,13 +61,12 @@ DIALOG_TASK(reimu, Stage1PreBoss) { | |||
MSG(cirno, "What, are you *that* impressed by my incredible magic?!"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I don't really like this whole interaction, especially Cirno's lines. Think you can give a shot at rewriting it?
c486e6d
to
a32e9dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just skimmed through it again, LGTM % comment. Still haven't tested in-game though.
src/dialog/youmu.c
Outdated
@@ -264,7 +264,7 @@ DIALOG_TASK(youmu, Stage4PreBoss) { | |||
|
|||
FACE(kurumi, dissastisfied); | |||
MSG(kurumi, "Of course not! Who do you take me for?!"); | |||
MSG(kurumi, "No WAY I’d want to associate myself with the people running this mansion!"); | |||
MSG(kurumi, "No WAY I’d want to associate myself with the idiot running this mansion!"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plural?
I still think something like dorks or dweebs would be more fitting here since she's insulting their fashion sense rather than intelligence… and Taisei!Yumemi does strike me as a bit socially inept.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo comment.
src/dialog/reimu.c
Outdated
FACE(cirno, defeated); | ||
MSG(cirno, "Cool down! I didn’t mean it like that!"); | ||
MSG(cirno, "Chill out! I didn’t mean it like that!"); | ||
FACE(reimu, smug); | ||
MSG(reimu, "I did say you could just let me through, you know."); | ||
MSG(reimu, "You could have just let me through, you know."); | ||
MSG(cirno, "I don’t remember that! You broke the rules! I wasn’t ready yet…"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "I don't remember that" line makes little sense now… remember what?
Initial dialogue/story edits for 2023, since it's been a while since this was all written.
Draft for now.