Fix OpenSSL 3.0 deprecation error for SHA256 functions #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akaricchi
reviewed
May 9, 2022
StarWitch
force-pushed
the
fix_openssl_deprecation
branch
2 times, most recently
from
528e1b0 to
6114c95
Compare
|
LGTM except the stage2 commit doesn't belong here. I suggest pushing that to master first and then rebasing this PR (can squish all the commits as well while you're at it) |
PR review changes add libssl to test suite fix segfault
StarWitch
force-pushed
the
fix_openssl_deprecation
branch
from
1d7d9f7 to
118fcfb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small fix for compiling with OpenSSL 3.0. As of 3.0, the
SHA256_*functions are deprecated in favour ofEVP_*functions, which then triggers an error when-Werroris enabled.Functionality is the same, and I streamlined things slightly. There's also a single-line change for eliminating an unused variable error.