Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Title Cards #220

Closed
wants to merge 10 commits into from
Closed

Title Cards #220

wants to merge 10 commits into from

Conversation

StarWitch
Copy link
Member

Still very much a WIP, and very rough. This gives the boss characters "title cards" which pop in when queued in the dialogue, and then fade out after a preset time, like mainline Touhou games.

Since this is a highly-visual sort of change, I'm looking for feedback in terms of style, position, animation, etc. and anything else we want this bit of flair to do.

@Akaricchi Akaricchi self-requested a review April 26, 2020 01:08
@StarWitch StarWitch marked this pull request as draft April 26, 2020 01:27
@StarWitch StarWitch changed the title WIP: Title Cards Title Cards Apr 26, 2020
Copy link
Member

@Akaricchi Akaricchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a general code review; no comment on the appearance for now.

src/dialog.c Outdated Show resolved Hide resolved
src/dialog.c Show resolved Hide resolved
src/dialog.c Outdated Show resolved Hide resolved
src/dialog.h Outdated Show resolved Hide resolved
src/dialog.h Outdated Show resolved Hide resolved
src/dialog.h Outdated Show resolved Hide resolved
src/dialog.h Outdated Show resolved Hide resolved
@StarWitch
Copy link
Member Author

Changes done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants