Fix issue with Tailwind modifying global state #9294
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running Tailwind, it modifies the plugin defaults parameters. As a result Tailwind using a Tailwind plugin in the same process twice yields different results.
For reproduction, run the following script (Use native ESM):
As you can see, in the output,
#abcdef
is present in the third run, because the second run has added it to some internal state.I have narrowed down the issue to these lines:
tailwindcss/src/util/resolveConfig.js
Lines 271 to 276 in db50bbb
I have refrained from writing a test yet, because although these changes fix it and all tests pass, it feels like it should be fixed somewhere else.