Handle variants on complex selectors #9262
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a utility .foo.bar we would replace the candidate class in-place. This resulted in a problem where we'd produce something like the following for
peer-checked:bar
:This is obviously a mistake as it completely mangles the original meaning of the selector. This PR fixes this.
Fixes #9056
This, however, opens an interesting question:
When given a utility like
.foo .bar
the replacement is fairly simple for eitherhover:foo
orhover:bar
. But what aboutgroup-hover:foo
,peer-checked:foo
,group-hover:bar
, andpeer-checked:bar
?With this there are obvious interpretations for
foo
but not necessarily so forbar
:We've decided that, while it may not suit all use cases, the best way to approach this is to slot in the entire variant selector in the spot where the class candidate is. As such the variants for foo and bar above will produce the following: