Enable postcss-import in the CLI by default in watch mode
#8574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adambrgmn
commented
Jun 10, 2022
Instead of relying on a arbitrary setTimout value, let's wait for the file to be created instead.
RobinMalfait
changed the title
postcss-import in the CLI by default in watch mode
|
Hey! Thank you for your PR! I created a new PR #8580 and started from your PR but made a few small changes and rebased onto the |
|
Thank you @RobinMalfait 🙏 |
47 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #8437 added support for
postcss-importby default intailwind-csscli. But watch mode was forgotten. This PR addspostcss-importas a built-in plugin in both watch mode and regular build mode.Changes:
Thanks for a great project! ❤️ Hope it's okey that I went straight ahead and submitted a PR before opening an issue. Let me know if you want me to close and go that route instead.