Quick fix for incorrect arbitrary properties when using URLs #7252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out that using links like [https://example.com] causes arbitrary properties to generate invalid css. This is a very dirty quick fix for this specific case, so we have to fix this properly!
RobinMalfait
changed the title
dukex
added a commit
to dukex/tailwindcss-rails
that referenced
this pull request
Feb 15, 2022
# CHANGELOG ## [3.0.22] - 2022-02-11 ### Fixed - Temporarily move postcss to dependencies ([#7424](tailwindlabs/tailwindcss#7424)) ## [3.0.21] - 2022-02-10 ### Fixed - Move prettier plugin to dev dependencies ([#7418](tailwindlabs/tailwindcss#7418)) ## [3.0.20] - 2022-02-10 ### Added - Expose `context.sortClassList(classes)` ([#7412](tailwindlabs/tailwindcss#7412)) ## [3.0.19] - 2022-02-07 ### Fixed - Fix preflight border color fallback ([#7288](tailwindlabs/tailwindcss#7288)) - Correctly parse shadow lengths without a leading zero ([#7289](tailwindlabs/tailwindcss#7289)) - Don't crash when scanning extremely long class candidates ([#7331](tailwindlabs/tailwindcss#7331)) - Use less hacky fix for URLs detected as custom properties ([#7275](tailwindlabs/tailwindcss#7275)) - Correctly generate negative utilities when dash is before the prefix ([#7295](tailwindlabs/tailwindcss#7295)) - Detect prefixed negative utilities in the safelist ([#7295](tailwindlabs/tailwindcss#7295)) ## [3.0.18] - 2022-01-28 ### Fixed - Fix `@apply` order regression (in `addComponents`, `addUtilities`, ...) ([#7232](tailwindlabs/tailwindcss#7232)) - Quick fix for incorrect arbitrary properties when using URLs ([#7252](tailwindlabs/tailwindcss#7252)) ## [3.0.17] - 2022-01-26 ### Fixed - Remove false positive warning in CLI when using the `--content` option ([#7220](tailwindlabs/tailwindcss#7220)) ## [3.0.16] - 2022-01-24 ### Fixed - Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) ([#7080](tailwindlabs/tailwindcss#7080)) - Improve various warnings ([#7118](tailwindlabs/tailwindcss#7118)) - Fix grammatical mistake ([cca5a38](tailwindlabs/tailwindcss@cca5a38))
dhh
pushed a commit
to rails/tailwindcss-rails
that referenced
this pull request
Feb 19, 2022
# CHANGELOG ## [3.0.22] - 2022-02-11 ### Fixed - Temporarily move postcss to dependencies ([#7424](tailwindlabs/tailwindcss#7424)) ## [3.0.21] - 2022-02-10 ### Fixed - Move prettier plugin to dev dependencies ([#7418](tailwindlabs/tailwindcss#7418)) ## [3.0.20] - 2022-02-10 ### Added - Expose `context.sortClassList(classes)` ([#7412](tailwindlabs/tailwindcss#7412)) ## [3.0.19] - 2022-02-07 ### Fixed - Fix preflight border color fallback ([#7288](tailwindlabs/tailwindcss#7288)) - Correctly parse shadow lengths without a leading zero ([#7289](tailwindlabs/tailwindcss#7289)) - Don't crash when scanning extremely long class candidates ([#7331](tailwindlabs/tailwindcss#7331)) - Use less hacky fix for URLs detected as custom properties ([#7275](tailwindlabs/tailwindcss#7275)) - Correctly generate negative utilities when dash is before the prefix ([#7295](tailwindlabs/tailwindcss#7295)) - Detect prefixed negative utilities in the safelist ([#7295](tailwindlabs/tailwindcss#7295)) ## [3.0.18] - 2022-01-28 ### Fixed - Fix `@apply` order regression (in `addComponents`, `addUtilities`, ...) ([#7232](tailwindlabs/tailwindcss#7232)) - Quick fix for incorrect arbitrary properties when using URLs ([#7252](tailwindlabs/tailwindcss#7252)) ## [3.0.17] - 2022-01-26 ### Fixed - Remove false positive warning in CLI when using the `--content` option ([#7220](tailwindlabs/tailwindcss#7220)) ## [3.0.16] - 2022-01-24 ### Fixed - Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) ([#7080](tailwindlabs/tailwindcss#7080)) - Improve various warnings ([#7118](tailwindlabs/tailwindcss#7118)) - Fix grammatical mistake ([cca5a38](tailwindlabs/tailwindcss@cca5a38))
aisen-lopez
pushed a commit
to aisen-lopez/rails-tailwindcss-template
that referenced
this pull request
Apr 1, 2022
# CHANGELOG ## [3.0.22] - 2022-02-11 ### Fixed - Temporarily move postcss to dependencies ([#7424](tailwindlabs/tailwindcss#7424)) ## [3.0.21] - 2022-02-10 ### Fixed - Move prettier plugin to dev dependencies ([#7418](tailwindlabs/tailwindcss#7418)) ## [3.0.20] - 2022-02-10 ### Added - Expose `context.sortClassList(classes)` ([#7412](tailwindlabs/tailwindcss#7412)) ## [3.0.19] - 2022-02-07 ### Fixed - Fix preflight border color fallback ([#7288](tailwindlabs/tailwindcss#7288)) - Correctly parse shadow lengths without a leading zero ([#7289](tailwindlabs/tailwindcss#7289)) - Don't crash when scanning extremely long class candidates ([#7331](tailwindlabs/tailwindcss#7331)) - Use less hacky fix for URLs detected as custom properties ([#7275](tailwindlabs/tailwindcss#7275)) - Correctly generate negative utilities when dash is before the prefix ([#7295](tailwindlabs/tailwindcss#7295)) - Detect prefixed negative utilities in the safelist ([#7295](tailwindlabs/tailwindcss#7295)) ## [3.0.18] - 2022-01-28 ### Fixed - Fix `@apply` order regression (in `addComponents`, `addUtilities`, ...) ([#7232](tailwindlabs/tailwindcss#7232)) - Quick fix for incorrect arbitrary properties when using URLs ([#7252](tailwindlabs/tailwindcss#7252)) ## [3.0.17] - 2022-01-26 ### Fixed - Remove false positive warning in CLI when using the `--content` option ([#7220](tailwindlabs/tailwindcss#7220)) ## [3.0.16] - 2022-01-24 ### Fixed - Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) ([#7080](tailwindlabs/tailwindcss#7080)) - Improve various warnings ([#7118](tailwindlabs/tailwindcss#7118)) - Fix grammatical mistake ([cca5a38](tailwindlabs/tailwindcss@cca5a38))
anderscain63
added a commit
to anderscain63/tailwindcss-rails
that referenced
this pull request
Dec 20, 2022
# CHANGELOG ## [3.0.22] - 2022-02-11 ### Fixed - Temporarily move postcss to dependencies ([#7424](tailwindlabs/tailwindcss#7424)) ## [3.0.21] - 2022-02-10 ### Fixed - Move prettier plugin to dev dependencies ([#7418](tailwindlabs/tailwindcss#7418)) ## [3.0.20] - 2022-02-10 ### Added - Expose `context.sortClassList(classes)` ([#7412](tailwindlabs/tailwindcss#7412)) ## [3.0.19] - 2022-02-07 ### Fixed - Fix preflight border color fallback ([#7288](tailwindlabs/tailwindcss#7288)) - Correctly parse shadow lengths without a leading zero ([#7289](tailwindlabs/tailwindcss#7289)) - Don't crash when scanning extremely long class candidates ([#7331](tailwindlabs/tailwindcss#7331)) - Use less hacky fix for URLs detected as custom properties ([#7275](tailwindlabs/tailwindcss#7275)) - Correctly generate negative utilities when dash is before the prefix ([#7295](tailwindlabs/tailwindcss#7295)) - Detect prefixed negative utilities in the safelist ([#7295](tailwindlabs/tailwindcss#7295)) ## [3.0.18] - 2022-01-28 ### Fixed - Fix `@apply` order regression (in `addComponents`, `addUtilities`, ...) ([#7232](tailwindlabs/tailwindcss#7232)) - Quick fix for incorrect arbitrary properties when using URLs ([#7252](tailwindlabs/tailwindcss#7252)) ## [3.0.17] - 2022-01-26 ### Fixed - Remove false positive warning in CLI when using the `--content` option ([#7220](tailwindlabs/tailwindcss#7220)) ## [3.0.16] - 2022-01-24 ### Fixed - Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) ([#7080](tailwindlabs/tailwindcss#7080)) - Improve various warnings ([#7118](tailwindlabs/tailwindcss#7118)) - Fix grammatical mistake ([cca5a38](tailwindlabs/tailwindcss@cca5a38))
titan2gman
added a commit
to titan2gman/tailwindcss-rails
that referenced
this pull request
Dec 27, 2022
# CHANGELOG ## [3.0.22] - 2022-02-11 ### Fixed - Temporarily move postcss to dependencies ([#7424](tailwindlabs/tailwindcss#7424)) ## [3.0.21] - 2022-02-10 ### Fixed - Move prettier plugin to dev dependencies ([#7418](tailwindlabs/tailwindcss#7418)) ## [3.0.20] - 2022-02-10 ### Added - Expose `context.sortClassList(classes)` ([#7412](tailwindlabs/tailwindcss#7412)) ## [3.0.19] - 2022-02-07 ### Fixed - Fix preflight border color fallback ([#7288](tailwindlabs/tailwindcss#7288)) - Correctly parse shadow lengths without a leading zero ([#7289](tailwindlabs/tailwindcss#7289)) - Don't crash when scanning extremely long class candidates ([#7331](tailwindlabs/tailwindcss#7331)) - Use less hacky fix for URLs detected as custom properties ([#7275](tailwindlabs/tailwindcss#7275)) - Correctly generate negative utilities when dash is before the prefix ([#7295](tailwindlabs/tailwindcss#7295)) - Detect prefixed negative utilities in the safelist ([#7295](tailwindlabs/tailwindcss#7295)) ## [3.0.18] - 2022-01-28 ### Fixed - Fix `@apply` order regression (in `addComponents`, `addUtilities`, ...) ([#7232](tailwindlabs/tailwindcss#7232)) - Quick fix for incorrect arbitrary properties when using URLs ([#7252](tailwindlabs/tailwindcss#7252)) ## [3.0.17] - 2022-01-26 ### Fixed - Remove false positive warning in CLI when using the `--content` option ([#7220](tailwindlabs/tailwindcss#7220)) ## [3.0.16] - 2022-01-24 ### Fixed - Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) ([#7080](tailwindlabs/tailwindcss#7080)) - Improve various warnings ([#7118](tailwindlabs/tailwindcss#7118)) - Fix grammatical mistake ([cca5a38](tailwindlabs/tailwindcss@cca5a38))
smartech7
pushed a commit
to smartech7/rails-tailwind-css
that referenced
this pull request
Aug 4, 2023
# CHANGELOG ## [3.0.22] - 2022-02-11 ### Fixed - Temporarily move postcss to dependencies ([#7424](tailwindlabs/tailwindcss#7424)) ## [3.0.21] - 2022-02-10 ### Fixed - Move prettier plugin to dev dependencies ([#7418](tailwindlabs/tailwindcss#7418)) ## [3.0.20] - 2022-02-10 ### Added - Expose `context.sortClassList(classes)` ([#7412](tailwindlabs/tailwindcss#7412)) ## [3.0.19] - 2022-02-07 ### Fixed - Fix preflight border color fallback ([#7288](tailwindlabs/tailwindcss#7288)) - Correctly parse shadow lengths without a leading zero ([#7289](tailwindlabs/tailwindcss#7289)) - Don't crash when scanning extremely long class candidates ([#7331](tailwindlabs/tailwindcss#7331)) - Use less hacky fix for URLs detected as custom properties ([#7275](tailwindlabs/tailwindcss#7275)) - Correctly generate negative utilities when dash is before the prefix ([#7295](tailwindlabs/tailwindcss#7295)) - Detect prefixed negative utilities in the safelist ([#7295](tailwindlabs/tailwindcss#7295)) ## [3.0.18] - 2022-01-28 ### Fixed - Fix `@apply` order regression (in `addComponents`, `addUtilities`, ...) ([#7232](tailwindlabs/tailwindcss#7232)) - Quick fix for incorrect arbitrary properties when using URLs ([#7252](tailwindlabs/tailwindcss#7252)) ## [3.0.17] - 2022-01-26 ### Fixed - Remove false positive warning in CLI when using the `--content` option ([#7220](tailwindlabs/tailwindcss#7220)) ## [3.0.16] - 2022-01-24 ### Fixed - Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) ([#7080](tailwindlabs/tailwindcss#7080)) - Improve various warnings ([#7118](tailwindlabs/tailwindcss#7118)) - Fix grammatical mistake ([cca5a38](tailwindlabs/tailwindcss@cca5a38))
XLoopLion
added a commit
to XLoopLion/tailwindcss-rails
that referenced
this pull request
Jun 12, 2024
# CHANGELOG ## [3.0.22] - 2022-02-11 ### Fixed - Temporarily move postcss to dependencies ([#7424](tailwindlabs/tailwindcss#7424)) ## [3.0.21] - 2022-02-10 ### Fixed - Move prettier plugin to dev dependencies ([#7418](tailwindlabs/tailwindcss#7418)) ## [3.0.20] - 2022-02-10 ### Added - Expose `context.sortClassList(classes)` ([#7412](tailwindlabs/tailwindcss#7412)) ## [3.0.19] - 2022-02-07 ### Fixed - Fix preflight border color fallback ([#7288](tailwindlabs/tailwindcss#7288)) - Correctly parse shadow lengths without a leading zero ([#7289](tailwindlabs/tailwindcss#7289)) - Don't crash when scanning extremely long class candidates ([#7331](tailwindlabs/tailwindcss#7331)) - Use less hacky fix for URLs detected as custom properties ([#7275](tailwindlabs/tailwindcss#7275)) - Correctly generate negative utilities when dash is before the prefix ([#7295](tailwindlabs/tailwindcss#7295)) - Detect prefixed negative utilities in the safelist ([#7295](tailwindlabs/tailwindcss#7295)) ## [3.0.18] - 2022-01-28 ### Fixed - Fix `@apply` order regression (in `addComponents`, `addUtilities`, ...) ([#7232](tailwindlabs/tailwindcss#7232)) - Quick fix for incorrect arbitrary properties when using URLs ([#7252](tailwindlabs/tailwindcss#7252)) ## [3.0.17] - 2022-01-26 ### Fixed - Remove false positive warning in CLI when using the `--content` option ([#7220](tailwindlabs/tailwindcss#7220)) ## [3.0.16] - 2022-01-24 ### Fixed - Ensure to transpile the PostCSS Nesting plugin (tailwindcss/nesting) ([#7080](tailwindlabs/tailwindcss#7080)) - Improve various warnings ([#7118](tailwindlabs/tailwindcss#7118)) - Fix grammatical mistake ([cca5a38](tailwindlabs/tailwindcss@cca5a38))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very dirty quick fix for this specific case, so we have to fix
this properly!
Turns out that using links like [https://example.com] causes arbitrary
properties to generate invalid css.
Fixes: #7251