-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow all classes for @apply #6580
Allow all classes for @apply #6580
Conversation
Hey! Thank you for your bug report! If I run your tests against the current |
52a4bd9
to
21413ea
Compare
@RobinMalfait, thanks for fixing this 👍 #6589 However, I noticed it's required to reference it('should pickup all classes', () => {
let config = {
content: [{ raw: html`<div class="foo"></div>` }],
plugins: [],
}
let input = css`
@tailwind; /* remove me I break */
.bop {
color: red;
}
.bar {
background-color: blue;
}
.foo {
@apply absolute bar bop;
}
`
return run(input, config).then((result) => {
return expect(result.css).toMatchFormattedCss(css`
@tailwind;
.bop {
color: red;
}
.bar {
background-color: blue;
}
.foo {
position: absolute;
color: red;
background-color: blue;
}
`)
})
})
|
I found its due to an optimization where css files without a directive are ignored: Removing the condition to allows the test to pass. |
21413ea
to
9446822
Compare
9446822
to
19c3000
Compare
@RobinMalfait I've updated my PR with a solution that maintains the optimization for css without @tailwind or @apply |
# Conflicts: # src/lib/setupWatchingContext.js
To match the style of the surrounding code
They do not need to be returned here. If it's needed in the future its easy enough to add it back.
Relates to #6321