Don't mutate custom color palette when overriding per-plugin colors #6546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
changed the title
thecrypticace
force-pushed
the
fix/6503
branch
from
421b66b
to
0a30c58
Compare
thecrypticace
force-pushed
the
fix/6503
branch
from
0a30c58
to
f1951d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6503
Previously when overriding the main color palette and extending per-plugin colors the colors object itself could get mutated when:
When merging extensions we would write properties from each of the plugins into the object color palette. The workaround is to deeply-clone objects after resolving them.